Opened 6 years ago

Closed 6 years ago

#1660 closed defect (fixed)

petascope log improvements

Reported by: Dimitar Misev Owned by: Bang Pham Huu
Priority: major Milestone: 9.5
Component: petascope Version: development
Keywords: Cc: Peter Baumann
Complexity: Medium

Description (last modified by Dimitar Misev)

The startup log can be improved, here's a suggestion: https://www.diffchecker.com/K2KSwtdk

Below, 66 what? ms? I would word it as rasql query executed in 66 ms.

 DEBUG [11:42:46] RasUtil@229: Total time for rasql: 66

Here I see three identical logs for the rasql query basically. Only one is enough (RasUtil@142 I guess), the others should be removed:

 DEBUG [11:42:49] KVPWCSProcessCoverageHandler@114: Executing rasql query: SELECT encode(c[0:885,0:710], "png" , "{\"geoReference\":{\"crs\":\"EPSG:4326\",\"bbox\":{\"xmin\":111.975,\"ymin\":-44.525,\"xmax\":156.275,\"ymax\":-8.975}
}}") FROM test_mean_summer_airtemp AS c
 DEBUG [11:42:49] RasUtil@92: Execute rasql query 'SELECT encode(c[0:885,0:710], "png" , "{\"geoReference\":{\"crs\":\"EPSG:4326\",\"bbox\":{\"xmin\":111.975,\"ymin\":-44.525,\"xmax\":156.275,\"ymax\":-8.975}}}") FROM test_mean_summ
er_airtemp AS c'.
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@603a636e
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@591359e9
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3fccc3a4
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3d6abc0a
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@e7899da
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@4de745ed
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@146f6e16
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@7c0d1a7d
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@36f1ea6f
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@41ce0971
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@2e3ed080
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3af4f9c8
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3efce6b
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@32dbdae6
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@6ab9b6ed
 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@771e28cb
 TRACE [11:42:49] RasUtil@142: Executing query SELECT encode(c[0:885,0:710], "png" , "{\"geoReference\":{\"crs\":\"EPSG:4326\",\"bbox\":{\"xmin\":111.975,\"ymin\":-44.525,\"xmax\":156.275,\"ymax\":-8.975}}}") FROM test_mean_summer_a
irtemp AS c

There are too many of these logs, they should be blocked somehow (e.g. configure properly log4j of the libraries used in petascope):

 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@771e28cb
 ...
 DEBUG [11:42:49] PoolThreadCache@81: Freed 1 thread-local buffer(s) from thread: threadDeathWatcher-3-2

There's duplication about the 'coverage id read from cache' (I think that log statement could be completely removed, it's not very useful at all):

 DEBUG [11:42:50] PetascopeController@90: Received request: coverageId=test_mean_summer_airtemp&format=image/png&request=GetCoverage&service=WCS&version=2.0.1
 DEBUG [11:42:50] AbstractHandler@90: Found the request handler: petascope.controller.handler.service.KVPWCSServiceHandler
 DEBUG [11:42:50] CoverageRepostioryService@119: Coverage id 'test_mean_summer_airtemp' is read from cache.
 DEBUG [11:42:50] ResponseService@128: Generated a single WCPS query from WCS request: for c in (test_mean_summer_airtemp) return encode(c[Lat(-44.525:-8.975), Long(111.975:156.275)], "png")
 DEBUG [11:42:50] CoverageRepostioryService@119: Coverage id 'test_mean_summer_airtemp' is read from cache.

This should not be INFO:

  INFO [11:40:17] TypeRegistry@202: Succesfully initiated the type registry. Contents: {RGBSet...

best split it like this (notice also some fixed typos!):

  INFO [11:40:17] TypeRegistry@202: Successfully initialized the type registry. 
  TRACE [11:40:17] TypeRegistry@202: Contents: {RGBSet...

Change History (5)

comment:1 by Dimitar Misev, 6 years ago

Component: undecidedpetascope
Milestone: 9.5
Owner: set to Bang Pham Huu
Status: newassigned

comment:2 by Dimitar Misev, 6 years ago

Cc: Peter Baumann added
Description: modified (diff)

comment:3 by Dimitar Misev, 6 years ago

Summary: petascope NioEventLoop TRACE logspetascope log improvements

comment:4 by Dimitar Misev, 6 years ago

Another issue, maven generates too much log output in the installer log (rasdaman.install.log) and it makes it very unreadable. E.g just a small excerpt:

Downloading: https://repo.maven.apache.org/maven2/com/google/guava/guava/18.0/guava-18.0.jar
132/150 KB   86/86 KB                           \r136/150 KB   86/86 KB   \r140/150 KB   86/86 KB   \r144/150 KB   86/86 KB   \r3/18 KB   144/150 KB   86/86 KB   \r5/18 KB   144/150 KB   
86/86 KB   \r8/18 KB   144/150 KB   86/86 KB   \r11/18 KB   144/150 KB   86/86 KB   \r11/18 KB 
  144/150 KB   4/36 KB   86/86 KB   \r11/18 KB   144/150 KB   8/36 KB   86/86 KB   \r11/18 KB  
 144/150 KB   12/36 KB   86/86 KB   \r13/18 KB   144/150 KB   12/36 KB   86/86 KB   \r13/18 KB 
  144/150 KB   16/36 KB   86/86 KB   \r16/18 KB   144/150 KB   16/36 KB   86/86 KB   \r16/18 KB   
144/150 KB   20/36 KB   86/86 KB   \r16/18 KB   144/150 KB   24/36 KB   86/86 KB   \r16/18 KB   
144/150 KB   28/36 KB   86/86 KB   \r18/18 KB   144/150 KB   28/36 KB   86/86 KB   \r18/18 KB   144/150 KB   32/36 KB   86/86 KB   \r18/18 KB   144/150 KB   36/36 KB   86/86 KB   \r18/18 KB   
144/150 KB   36/36 KB   86/86 KB   \r18/18 KB   148/150 KB   36/36 KB   86/86 KB   \r18/18 KB   150/150 KB   36/36 KB   86/86 KB   \r18/18 KB   150/150 KB   36/36 KB   86/86 KB   4/2204 KB   \r18/18 KB   150/150 KB   36/36 KB   86/86 KB   8/2204 KB   \r18/18 KB   150/150 KB   36/36 KB   86/86 KB   12/2204 KB   \r18/18 KB   150/150 KB   36/36 KB   86/86 KB   16/2204 KB   \r                                                           \r18/18 KB   36/36 KB   86/86 KB   20/2204 KB                \r18/18 KB   36/36 KB   86/86 KB   24/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   28/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   32/2204 KB   \rDownloaded: https://repo.maven.apache.org/maven2/org/jdom/jdom/1.1/jdom-1.1.jar (150 KB at 2821.3 KB/sec)
18/18 KB   36/36 KB   86/86 KB   36/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   40/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   44/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   48/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   52/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   56/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   60/2204 KB   \r18/18 KB   36/36 KB   86/86 KB   64/2204 KB   \r                                              \r18/18 KB   36/36 KB   68/2204 KB           
   \rDownloaded: https://repo.maven.apache.org/maven2/commons-io/commons-io/1.3.2/commons-io-1.3.2.jar (86 KB at 1948.2 KB/sec)

18/18 KB   36/36 KB   72/2204 KB   \r18/18 KB   36/36 KB   76/2204 KB   \r18/18 KB   36/36 KB  
 80/2204 KB   \r18/18 KB   36/36 KB   84/2204 KB   \r                                   \r     
                              \rDownloaded: https://repo.maven.apache.org/maven2/asm/asm-analysis/3.2/asm-analysis-3.2.jar (18 KB at 462.2 KB/sec)

Downloaded: https://repo.maven.apache.org/maven2/asm/asm-util/3.2/asm-util-3.2.jar (36 KB at 
939.3 KB/sec)

88/2204 KB                         \r92/2204 KB   \r96/2204 KB   \r100/2204 KB   \r104/2204 KB  
 \r108/2204 KB   \r112/2204 KB   \r116/2204 KB   \r120/2204 KB   \r124/2204 KB   \r128/2204 KB  
 \r132/2204 KB   \r136/2204 KB   \r140/2204 KB   \r144/2204 KB   \r148/2204 KB   \r152/2204 KB 
  \r156/2204 KB   \r160/2204 KB   \r164/2204 KB   \r168/2204 KB   \r172/2204 KB   \r176/2204 KB   \r180/2204 KB   \r184/2204 KB   \r188/2204 KB   \r192/2204 KB   \r196/2204 KB   \r200/2204 KB  
 \r204/2204 KB   \r208/2204 KB   \r212/2204 KB   \r216/2204 KB   \r220/2204 KB   \r224/2204 KB 
  \r228/2204 KB   \r232/2204 KB   \r236/2204 KB   \r240/2204 KB   \r244/2204 KB   \r248/2204 KB
   \r252/2204 KB   \r256/2204 KB   \r260/2204 KB   \r264/2204 KB   \r268/2204 KB   \r272/2204 KB   \r276/2204 KB   \r280/2204 KB   \r284/2204 KB   \r288/2204 KB   \r292/2204 KB   \r296/2204 KB  
 \r300/2204 KB   \r304/2204 KB   \r308/2204 KB   \r312/2204 KB   \r316/2204 KB   \r320/2204 KB 
  \r324/2204 KB   \r328/2204 KB   \r332/2204 KB   \r336/2204 KB   \r340/2204 KB   \r344/2204 KB   \r348/2204 KB   \r352/2204 KB   \r356/2204 KB   \r360/2204 KB   \r364/2204 KB   \r368/2204 KB  
 \r372/2204 KB   \r376/2204 KB   \r380/2204 KB   \r384/2204 KB   \r388/2204 KB   \r392/2204 KB
   \r396/2204 KB   \r400/2204 KB   \r404/2204 KB   \r408/2204 KB   \r412/2204 KB   \r416/2204 KB   \r420/2204 KB   \r424/2204 KB   \r428/2204 KB   \r432/2204 KB   \r436/2204 KB   \r440/2204 KB  
 \r444/2204 KB   \r448/2204 KB   \r452/2204 KB   \r456/2204 KB   \r460/2204 KB   \r464/2204 KB   \r468/2204 KB   \r472/2204 KB   \r476/2204 KB   \r480/2204 KB   \r484/2204 KB   \r488/2204 KB  
 \r492/2204 KB   \r496/2204 KB   \r500/2204 KB   \r504/2204 KB   \r508/2204 KB   \r512/2204 KB   \r516/2204 KB   \r520/2204 KB   \r524/2204 KB   \r528/2204 KB   \r532/2204 KB   \r536/2204 KB   
\r540/2204 KB   \r544/2204 KB   \r548/2204 KB   \r552/2204 KB   \r556/2204 KB   \r560/2204 KB   \r564/2204 KB   \r568/2204 KB   \r572/2204 KB   \r576/2204 KB   \r580/2204 KB   \r584/2204 KB   
\r588/2204 KB   \r592/2204 KB   \r596/2204 KB   \r600/2204 KB   \r604/2204 KB   \r608/2204 KB   \r612/2204 KB   \r616/2204 KB   \r620/2204 KB   \r624/2204 KB   \r628/2204 KB   \r632/2204 KB   
\r636/2204 KB   \r640/2204 KB   \r644/2204 KB   \r648/2204 KB   \r652/2204 KB   \r656/2204 KB   \r660/2204 KB   \r664/2204 KB   \r668/2204 KB   \r672/2204 KB   \r676/2204 KB   \r680/2204 KB   
\r684/2204 KB   \r688/2204 KB   \r692/2204 KB   \r696/2204 KB   \r700/2204 KB   \r704/2204 KB   \r708/2204 KB   \r712/2204 KB   \r716/2204 KB   \r720/2204 KB   \r724/2204 KB   \r728/2204 KB   
\r732/2204 KB   \r736/2204 KB   \r740/2204 KB   \r744/2204 KB   \r748/2204 KB   \r752/2204 KB   \r756/2204 KB   \r760/2204 KB   \r764/2204 KB   \r768/2204 KB   \r772/2204 KB   \r776/2204 KB   
\r780/2204 KB   \r784/2204 KB   \r788/2204 KB   \r792/2204 KB   \r796/2204 KB   \r800/2204 KB   
\r804/2204 KB   \r808/2204 KB   \r812/2204 KB   \r816/2204 KB   \r820/2204 KB   \r824/2204 KB   
\r828/2204 KB   \r832/2204 KB   \r836/2204 KB   \r840/2204 KB   \r844/2204 KB   \r848/2204 KB   
\r852/2204 KB   \r856/2204 KB   \r860/2204 KB   \r864/2204 KB   \r868/2204 KB   \r872/2204 KB   
\r876/2204 KB   \r880/2204 KB   \r884/2204 KB   \r888/2204 KB   \r892/2204 KB   \r896/2204 KB   
\r900/2204 KB   \r904/2204 KB   \r908/2204 KB   \r912/2204 KB   \r916/2204 KB   \r920/2204 KB   
\r924/2204 KB   \r928/2204 KB   \r932/2204 KB   \r936/2204 KB   \r940/2204 KB   \r944/2204 KB   
\r948/2204 KB   \r952/2204 KB   \r956/2204 KB   \r960/2204 KB   \r964/2204 KB   \r968/2204 KB   
\r972/2204 KB   \r976/2204 KB   \r980/2204 KB   \r984/2204 KB   \r988/2204 KB   \r992/2204 KB   
\r996/2204 KB   \r1000/2204 KB   \r1004/2204 KB   \r1008/2204 KB   \r1012/2204 KB   \r1016/2204 
KB   \r1020/2204 KB   \r1024/2204 KB   \r1028/2204 KB   \r1032/2204 KB   \r1036/2204 KB   
\r1040/2204 KB   \r1044/2204 KB   \r1048/2204 KB   \r1052/2204 KB   \r1056/2204 KB   \r1060/2204 
KB   \r1064/2204 KB   \r1068/2204 KB   \r1072/2204 KB   \r1076/2204 KB   \r1080/2204 KB   
\r1084/2204 KB   \r1088/2204 KB   \r1092/2204 KB   \r1096/2204 KB   \r1100/2204 KB   \r1104/2204 
KB   \r1108/2204 KB   \r1112/2204 KB   \r1116/2204 KB   \r1120/2204 KB   \r1124/2204 KB   
\r1128/2204 KB   \r1132/2204 KB   \r1136/2204 KB   \r1140/2204 KB   \r1144/2204 KB   \r1148/2204 
KB   \r1152/2204 KB   \r1156/2204 KB   \r1160/2204 KB   \r1164/2204 KB   \r1168/2204 KB   
\r1172/2204 KB   \r1176/2204 KB   \r1180/2204 KB   \r1184/2204 KB   \r1188/2204 KB   \r1192/2204 
KB   \r1196/2204 KB   \r1200/2204 KB   \r1204/2204 KB   \r1208/2204 KB   \r1212/2204 KB   
\r1216/2204 KB   \r1220/2204 KB   \r1224/2204 KB   \r1228/2204 KB   \r1232/2204 KB   \r1236/2204 
KB   \r1240/2204 KB   \r1244/2204 KB   \r1248/2204 KB   \r1252/2204 KB   \r1256/2204 KB   
\r1260/2204 KB   \r1264/2204 KB   \r1268/2204 KB   \r1272/2204 KB   \r1276/2204 KB   \r1280/2204 
KB   \r1284/2204 KB   \r1288/2204 KB   \r1292/2204 KB   \r1296/2204 KB   \r1300/2204 KB   
\r1304/2204 KB   \r1308/2204 KB   \r1312/2204 KB   \r1316/2204 KB   \r1320/2204 KB   \r1324/2204 
KB   \r1328/2204 KB   \r1332/2204 KB   \r1336/2204 KB   \r1340/2204 KB   \r1344/2204 KB   
\r1348/2204 KB   \r1352/2204 KB   \r1356/2204 KB   \r1360/2204 KB   \r1364/2204 KB   \r1368/2204 
KB   \r1372/2204 KB   \r1376/2204 KB   \r1380/2204 KB   \r1384/2204 KB   \r1388/2204 KB   
\r1392/2204 KB   \r1396/2204 KB   \r1400/2204 KB   \r1404/2204 KB   \r1408/2204 KB   \r1412/2204 
KB   \r1416/2204 KB   \r1420/2204 KB   \r1424/2204 KB   \r1428/2204 KB   \r1432/2204 KB   
\r1436/2204 KB   \r1440/2204 KB   \r1444/2204 KB   \r1448/2204 KB   \r1452/2204 KB   \r1456/2204 
KB   \r1460/2204 KB   \r1464/2204 KB   \r1468/2204 KB   \r1472/2204 KB   \r1476/2204 KB   
\r1480/2204 KB   \r1484/2204 KB   \r1488/2204 KB   \r1492/2204 KB   \r1496/2204 KB   \r1500/2204 
KB   \r1504/2204 KB   \r1508/2204 KB   \r1512/2204 KB   \r1516/2204 KB   \r1520/2204 KB   
\r1524/2204 KB   \r1528/2204 KB   \r1532/2204 KB   \r1536/2204 KB   \r1540/2204 KB   \r1544/2204 
KB   \r1548/2204 KB   \r1552/2204 KB   \r1556/2204 KB   \r1560/2204 KB   \r1564/2204 KB   
\r1568/2204 KB   \r1572/2204 KB   \r1576/2204 KB   \r1580/2204 KB   \r1584/2204 KB   \r1588/2204 
KB   \r1592/2204 KB   \r1596/2204 KB   \r1600/2204 KB   \r1604/2204 KB   \r1608/2204 KB   
\r1612/2204 KB   \r1616/2204 KB   \r1620/2204 KB   \r1624/2204 KB   \r1628/2204 KB   \r1632/2204 
KB   \r1636/2204 KB   \r1640/2204 KB   \r1644/2204 KB   \r1648/2204 KB   \r1652/2204 KB   
\r1656/2204 KB   \r1660/2204 KB   \r1664/2204 KB   \r1668/2204 KB   \r1672/2204 KB   \r1676/2204 
KB   \r1680/2204 KB   \r1684/2204 KB   \r1688/2204 KB   \r1692/2204 KB   \r1696/2204 KB   
\r1700/2204 KB   \r1704/2204 KB   \r1708/2204 KB   \r1712/2204 KB   \r1716/2204 KB   \r1720/2204 
KB   \r1724/2204 KB   \r1728/2204 KB   \r1732/2204 KB   \r1736/2204 KB   \r1740/2204 KB   
\r1744/2204 KB   \r1748/2204 KB   \r1752/2204 KB   \r1756/2204 KB   \r1760/2204 KB   \r1764/2204 
KB   \r1768/2204 KB   \r1772/2204 KB   \r1776/2204 KB   \r1780/2204 KB   \r1784/2204 KB   
\r1788/2204 KB   \r1792/2204 KB   \r1796/2204 KB   \r1800/2204 KB   \r1804/2204 KB   

comment:5 by Bang Pham Huu, 6 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.