Opened 11 years ago

Closed 8 years ago

#503 closed enhancement (fixed)

petascope_insertdemo.sh.in not to duplicate import statements

Reported by: Piero Campalani Owned by: Bang Pham Huu
Priority: minor Milestone: 9.2
Component: undecided Version: development
Keywords: petascope_insertdemo.sh.in import_mst Cc: Dimitar Misev
Complexity: Easy

Description

The script for inserting the demo coverage in petascopedb (mean_summer_airtemp) should not duplicate the SQL statements which are already defined in the systemtest.
Since systemtest sources are not shipped with RPM installations, this means that the script containing the import function must be either moved or copied to $RMANHOME/lib or share or similar during installation.

$ grep FIXME ./applications/petascope/src/main/db/petascope_insertdemo.sh.in
$ grep import_mst ./systemtest//util/petascope.sh

Change History (5)

comment:1 by Piero Campalani, 11 years ago

Meanwhile, changeset:cce4a8 reintroduced the duplicate bash function (though now updated for ps9_* schema) to let the script work as expected.

comment:2 by Dimitar Misev, 10 years ago

#534 should be unified as well, we need common parsing of port, host and similar options.

comment:3 by abeccati, 10 years ago

Complexity: MediumEasy
Priority: majorminor
Type: defectenhancement
Version: 8.5development

I think the insert demo functions should be taken as reference from the system tests for the following reason (correct me if my assumption is wrong):
systemtests are only available when cloning from source and not in a packaged release while the insert demo is always delivered to the user. Given that assumption, we will always have deployed the insertdemo which can be sourced from the systemtests. The other way around will not work and rpm users will not have means for loading some demo data to play with and see how it is loaded.

Updating version since 8.5 is now in maintenance mode and this is more a dev issue to engineer for upcoming releases. Changed to easy since it seems suitable for a beginner with bash knowledge and some guidance

comment:4 by Bang Pham Huu, 8 years ago

Owner: changed from Dimitar Misev to Bang Pham Huu
Status: newassigned

I will change rasimport to wcst_import as in ticket 1137, so this ticket can be closed here.

comment:5 by Bang Pham Huu, 8 years ago

Milestone: 9.0.x9.2
Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.