Opened 5 years ago

Closed 5 years ago

#2148 closed defect (fixed)

installation fails if tomcat not installed

Reported by: Peter Baumann Owned by: Dimitar Misev
Priority: major Milestone: 10.0
Component: build system Version: 9.8
Keywords: Cc: Vlad Merticariu, Dimitar Misev
Complexity: Easy

Description

The self-compile documentation does not list tomcat as a mandatory prerequisite, and the commands provided do not list it. However, "make install" breaks if tomcat is not installed.

Solution: add tomcat to (checked) dependencies, document how to install.

Change History (8)

comment:1 by Dimitar Misev, 5 years ago

It would be useful if you post the errors you get when "make install" breaks.

Tomcat is listed here: http://doc.rasdaman.org/02_inst-guide.html#install-required-packages

And you must have consciously specified the -DWAR_DIR=/var/lib/tomcat/webapps when executing cmake, documented as "The path where Java war files should be installed."

comment:2 by Dimitar Misev, 5 years ago

I think the right action here is to add a check in cmake:

if the path specified by -DWAR_DIR != the default, then check if the path exists and is writable.

comment:3 by Peter Baumann, 5 years ago

sounds good, still documentation should mention tomcat.

comment:4 by Dimitar Misev, 5 years ago

it does:

geo data support (optional):

    Tomcat (or another suitable servlet container) – required for running the 
    petascope and SECORE Java web applications

comment:5 by Peter Baumann, 5 years ago

  • geo data support: "…(optional)"
  • documentation says "Make sure also that your user is a member of the tomcat or tomcat7 group", but it tomcat is not in the list of prerequisites at http://doc.rasdaman.org/02_inst-guide.html#install-required-packages
  • "The path where Java war files should be installed." …why "should"? And again, this is not sufficiently explaining tomcat.

in reply to:  5 comment:6 by Dimitar Misev, 5 years ago

Replying to pbaumann:

  • geo data support: "…(optional)"

Yes it's optional dependency, when you compile rasdaman you can configure so that petascope doesn't get compiled at all.

Good point, this should be reworded to account for the optionality of tomcat.

  • "The path where Java war files should be installed." …why "should"? And again, this is not sufficiently explaining tomcat.

What's wrong with "should" here?

Tomcat is not a required dependency, these war files can run standalone as well without any Tomcat: http://doc.rasdaman.org/05_geo-services-guide.html#standalone-deployment

comment:7 by Dimitar Misev, 5 years ago

Owner: changed from Bang Pham Huu to Dimitar Misev
Status: newassigned

comment:8 by Dimitar Misev, 5 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.