Opened 7 years ago

Closed 5 years ago

#1567 closed defect (fixed)

valgrind for system tests

Reported by: Dimitar Misev Owned by: dkamov
Priority: major Milestone: 9.7
Component: systemtest Version: development
Keywords: memleak, test, valgrind Cc: Dimitar Misev, Vlad Merticariu, Peter Baumann
Complexity: Hard

Description (last modified by Dimitar Misev)

Add a systemtest/testcases_mandatory/test_memory_leaks/test.sh script that will run same as test_select, but use the following instead of rasql:

valgrind --tool=memcheck --leak-check=full --track-origins=yes directql ..

In the output/ directory the output of valgrind should be saved (not the query result like in test_select). The goal of the test is to look in this output from valgrind and determine if there is excessive memory leak. The oracle/ directory could contain the amount of maximum acceptable leaked bytes for each query.

Afterwards (in separate tickets) we can work to fix any memory leaks, and reduce the acceptable amounts in the oracle directory.

Change History (4)

comment:1 by Dimitar Misev, 7 years ago

Cc: Peter Baumann added

comment:2 by Dimitar Misev, 6 years ago

Description: modified (diff)
Milestone: 10.09.7
Owner: set to dkamov
Reporter: changed from bbell to Dimitar Misev
Status: newassigned

comment:3 by Dimitar Misev, 5 years ago

We have this test now in testcases_manual/test_memory, and it runs test_clipping, test_nullvalues, test_select, and test_subsetting through valgrind. It's a manual test (not automatically executed on make check) for two reasons:

  1. it takes a really long time to execute
  2. results vary across different OS so we can't reliably set some bounds on memory issues

comment:4 by Dimitar Misev, 5 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.