Petascope.properties lost many configuration after new install

[Bang Pham Huu]

Hi,

That problem appears recently (before I've tested a lot with Jetty so download and compile no problem), but maybe in 1 week and to now when I install Rasdaman normally (not yet Rasnet)

./configure --prefix=$RMANHOME --with-java-server=embedded
make
make install

File petascope.properties in /home/rasdaman/install/etc is like this

# parameter:   java_server 
# purpose: Allowing user to start Petascope with embedded (Jetty) or external (Tomcat) (use ./configure --with-java-server=embedded/external). 
# description: User could set to external Petascope or embedded Petascope. When setting to "embedded", user could start embedded Petascope after starting Rasdaman in script start_rasdaman.sh.  
# need to adapt: yes (depend on user environment), normally is external. 
java_server=embedded 

# parameter:	start_emdedded_petascope 
# purpose: Allowing user to start embedded Petascope after excute start_rasdaman.sh. 
# description: User could enable or disable Petascope with: permanent by configuration:"true/false" or temporary enable/disable when running script start_rasdaman.sh (example: "start_rasdaman.sh --stop-embedded-petascope" or "start_rasdaman --start-embedded-petascope"). 
# need to adapt: yes (depend on user environment), normally is false. 
start_embedded_petascope=true 

As you can see this is my new configurations to support embedded Jetty but where is the rest of this file? I suppose in makefile.am of Petascope has problem.

[Bang Pham Huu]

The problem looks like in here, not sure why

if test -f $$NEWCONF; then \ # if file petascope.properties is existed then update (OK)

else \ # but if file is not existed then do nothing (???) 
	
     echo "$@ will not overwrite existing $$NEWCONF";\
     fi; \

I will add the copy petascope.properties from resources to /install/etc/ and this could be solved.

[Peter Baumann]

this idea would overwrite existing customer settings. Also, patch has no tests.

[Dimitar Misev]

No Peter the patch is correct. If there is no existing petascope.properties then it should be installed.

[Dimitar Misev]

It is hard to test installation stuff like this, we do not have a systemtest for Makefiles.

[Bang Pham Huu]

This could be closed now (thanks for all).